Fix Issue #40 - #41
Open
daniel-moya wants to merge 1 commit into
Open
Conversation
daniel-moya
marked this pull request as ready for review
October 18, 2019 09:15
|
@damr67 Hello, your PR didn't completely solve the dependency problem, I found that the #36 has been perfectly solved, just did not merge into the master branch. I find that many people don't find that the problem has been solved, and I'm here to write down how to fetch an inactive request pull, hoping to help those in need. git clone https://github.com/EmailThis/extension-boilerplate.git
cd .\extension-boilerplate\
git fetch origin pull/36/head:genietim
git merge genietim |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump gulp-sass from 2.3.2 to 3.0.0 😄 (This Fix Issue #40)
Error when making
npm installI solved this by changing in package.json:
"gulp-sass": "^2.3.2"to
"gulp-sass": "3.0.0",codecombat/codecombat#4430 (comment)