feat(cooldown-manager): add text color customization for tracking bars - #1228
Open
Soothx wants to merge 1 commit into
Open
feat(cooldown-manager): add text color customization for tracking bars#1228Soothx wants to merge 1 commit into
Soothx wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds the ability to customize the text colors of Name, Duration and Stacks on Tracking Bars. Previously, the text was always
#FFFFFFwith0.9opacity. This lets the user pick any color. Personally, I made this because the slightly lower opacity white text, next to other completely white text, looked off slightly off.How was it tested?
I've tested by using various colors. This is only static colors, so it's only applied during
ApplyTrackedBuffBarSettings, where it persists. Color also applies correctly in the preview, and persists during reloads.Also tested on PTR target dummies.
Note: I do not seem to be able to get the "decimals" toggle to work on PTR, with or without the changes here.
GetBuildInfo()reports version120100.Screenshots
Before:

After:
Wow_n8cAW7Ghsa.mp4
Wow_89Otv6nVBU.mp4
Checklist
HookScript/hooksecurefunconly, neverSetScripton Blizzard frames