Skip to content

Fix addon compartment - #1223

Closed
RedAces wants to merge 1 commit into
EllesmereGaming:mainfrom
RedAces:fix-addon-compartment
Closed

Fix addon compartment#1223
RedAces wants to merge 1 commit into
EllesmereGaming:mainfrom
RedAces:fix-addon-compartment

Conversation

@RedAces

@RedAces RedAces commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

The addon compartement was not visible. Added it back!

How was it tested?

Tested on 12.0.7 Retail.
NOT tested on 12.1 PTR

Checklist

  • New settings default OFF (no behavior change without opt-in)
  • Zero cost while disabled: no events registered, no polling, no hooks doing work, no frames built
  • Cheap while enabled: event-driven (no polling, no timer-based logic, no per-frame allocations)
  • No writes onto Blizzard-owned frames (weak-table pattern used); HookScript/hooksecurefunc only, never SetScript on Blizzard frames
  • Tested in-game, works on live retail; no load errors on the 12.1 PTR client

@RedAces
RedAces force-pushed the fix-addon-compartment branch from d5c7a8d to f6704ae Compare August 6, 2026 19:14
It was reparented to a hidden frame unconditionally, so the
hideAddonCompartment setting had no effect. It is now pinned to the
minimap like the Omnium Folio (corner, offsets, scale) and toggleable
in the minimap options.
@RedAces
RedAces force-pushed the fix-addon-compartment branch from f6704ae to 050e97a Compare August 6, 2026 19:22
@EllesmereGaming

Copy link
Copy Markdown
Owner

manually merging this, in the middle of a major file structure change for 12.1, will be in with next patch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants