feat(qol): hold Artisan payouts at shard cap - #1216
Open
0x963D wants to merge 1 commit into
Open
Conversation
0x963D
marked this pull request as ready for review
August 6, 2026 14:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds an opt-in
Hold Capped Artisan Payoutssetting under Auto Open Containers.When enabled, Artisan's Consortium Payouts (item 246585) stay closed while Shard of Dundun (currency 3376) is at its total maximum. Automatic opening resumes after shards are spent. All other containers keep the existing behavior.
The setting defaults off and targets only this known payout/currency pair.
How was it tested?
git diff --check, and clean locale-key check.CURRENCY_DISPLAY_UPDATEonly while enabled, and unregisters it after restoring the setting.The exact capped-bag-slot hold could not be naturally exercised because neither test character simultaneously had a payout container and capped Shard of Dundun. The item/currency IDs and both client APIs were verified.
Screenshots
Retail problem evidence: Shard of Dundun at its 8/8 total cap (left), with five Artisan's Consortium Payouts ready to open (right):
Checklist
HookScript/hooksecurefunconly, neverSetScripton Blizzard frames (N/A: no Blizzard-frame mutation)