fix(questtracker): contain Blizzard quest icons within background - #1214
Open
0x963D wants to merge 1 commit into
Open
fix(questtracker): contain Blizzard quest icons within background#12140x963D wants to merge 1 commit into
0x963D wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Extends the addon-owned Quest Tracker background and divider far enough left to contain Blizzard's native quest icons when Show Quest Icons is enabled. Icon-disabled layouts keep the existing compact offset.
The right edge and tracker content alignment are unchanged. No Blizzard-owned frame or icon is modified.
Fixes #1197
How was it tested?
Lillydan-Thunderhorn: populated tracker with native icons, reload, and world map open/close.Lillydan-Anasterian: matched baseline/patched A/B, native icons enabled and disabled, and repeated reloads.taintLog 2: zero Quest Tracker / Objective Tracker matches on both clients after the tested interactions.luac5.1 -p, ASCII scan, andgit diff --check.TOPLEFTanchor uses the shared offset, with no new events, hooks, frames, timers, polling, or allocations.Not exercised because the available characters did not have those states ready: an empty tracker, a newly completed quest transition, live combat, and a new supertrack transition.
Screenshots
Matched 3440x1440 PTR captures at the same tracker position and UI scale:
Checklist
HookScript/hooksecurefunconly, neverSetScripton Blizzard frames