Localization: wrap remaining hardcoded strings with L(); fix the rep bar tooltip on paragon/renown factions - #1209
Merged
EllesmereGaming merged 9 commits intoAug 7, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
A sweep for user-facing strings that bypass the locale system. Every one of them
already has translations sitting unused in the repo's locale files (deDE has
"WENIG MANA", koKR has "낮은 마나", and so on) -- the call sites just never went
through
L():LOW MANALow Durability/Low Durability (%d%%)/Low Durability (Preview)Not BoundWeaponRenown,Paragon,Rested,House Level %d: %d / %dExperience,Level,XP,Remaining,Standing,Reputation,House Favor,Favor,House LevelOne real bug rides along, found while testing the wraps: the reputation
bar's tooltip recomputes its numbers from the raw watched-faction payload,
ignoring the paragon/renown/friendship handling the bar itself does. On a
paragon faction it shows the wrong standing and a negative value:
The bar now stashes its resolved standing/current/maximum on its own frame and
the tooltip reuses them, falling back to the raw payload only if the bar has
not rendered yet. No Blizzard frames involved.
Apart from that, all call sites are wraps only --
SetText("LOW MANA")becomesSetText(EllesmereUI.L("LOW MANA")), the one concatenation becomes anLfformat (
"Low Durability (" .. pct .. "%)"->Lf("Low Durability (%d%%)", pct),whose key the locale files already carry). No behaviour changes; on an enUS
client every string renders exactly as it does today.
Locales/_keys.txtis regenerated (+20 keys).Locales/koKR.luagains threelines for the format fragments that had no key yet -- every other key was already
translated -- and two existing values are corrected to Blizzard's official koKR
terms:
Renownwas "명성" but the koKR client labels renown "영예" (reputationpanel, renown toasts), and
Paragonwas "절정" but the paragon tooltip in thereputation panel is titled "최대 영예".
How was it tested?
Tested in game on live retail with a koKR client: the low-mana overlay, the
durability warning (live and preview), the Not Bound readouts in both options
panels, the reminders options preview row, and all three data bars with their
tooltips now render in Korean. Watching a paragon faction, the bar tooltip now
matches the bar (standing and positive cycle numbers) instead of showing a
negative reputation. No load errors.
Screenshots
N/A
Checklist