Skip to content

Refs #81768: Added checks to prevent creating additional indexes on _id field. #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
atifa-perveen wants to merge 2 commits into
base: feature-pymongo-upgrade
Choose a base branch
from
Open

Refs #81768: Added checks to prevent creating additional indexes on _id field. #4

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8c632a2
Refs #81768: Added checks to prevent creating additional indexes on _…
atifa-perveen Oct 10, 2018
0cf71e1
Indentation Fix
Nov 2, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions django_mongodb_engine/creation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,8 @@ def _handle_newstyle_indexes(self, ensure_index, meta, indexes):
# field doesn't need an index.
continue
column = '_id' if field.primary_key else field.column
ensure_index(column, unique=field.unique)
if not column == '_id':
ensure_index(column, unique=field.unique)

# Django unique_together indexes.
indexes = list(indexes)
Expand Down Expand Up @@ -122,10 +123,10 @@ def _handle_oldstyle_indexes(self, ensure_index, meta):
# field doesn't need an index.
continue
column = '_id' if field.primary_key else field.column
if field.name in descending_indexes:
column = [(column, DESCENDING)]
ensure_index(column, unique=field.unique,
sparse=field.name in sparse_indexes)
if not column == '_id':
if field.name in descending_indexes:
column = [(column, DESCENDING)]
ensure_index(column, unique=field.unique, sparse=field.name in sparse_indexes)

def create_compound_indexes(indexes, **kwargs):
# indexes: (field1, field2, ...).
Expand Down