feat: Allow debounce reload event - #21
Open
bjufre wants to merge 2 commits into
Open
Conversation
bjufre
force-pushed
the
feat/allow-debounce-reload-event
branch
from
June 29, 2023 08:44
f804e15 to
0de6d18
Compare
… ONE reload happens for a certain amount of time
bjufre
force-pushed
the
feat/allow-debounce-reload-event
branch
from
June 29, 2023 08:45
0de6d18 to
d2e859b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the possibility of debouncing the reload event so that it only happens once within a certain amount of time.
I had to patch the lib a couple times with this, so I thought if was already time to prepare the PR and send it.
On some projects, I'm generating some documentation on the fly for some Rails app, and this triggers maybe 10 reloads, and
puma-devbreaks because of it (see the example below) and we need to hard kill the process, wait, do it again, it breaks, etc, etc.