Repository navigation
[HUMANMADE] texture_cache: keep the Switch 1 GOB order when requested - #865
Open
LukeWarnut wants to merge 11 commits into
Open
LukeWarnut wants to merge 11 commits into
LukeWarnut wants to merge 11 commits into
Conversation
…kw-pipeline-cache-dir video_core: Fix shader cache folder creation for MKW
…d-vk-hardening vulkan: skip pipelines the driver refuses, harden texture cache and query copies
…he and query copies"
…evert-720-upstream/amd-vk-hardening Revert "vulkan: skip pipelines the driver refuses, harden texture cache and query copies"
…evert-812-video_core/mkw-pipeline-cache-dir Revert "video_core: Fix shader cache folder creation for MKW"
…abel it with its branch Scheduled runs use the default branch's workflow files, so the daily build of nx2-experimental was built with nx2's build-linux.yml. daily.yml now dispatches ci.yml on the daily branch instead, so it builds with that branch's own files. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
Retargeted to |
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
 |
Collaborator
|
hi could you rebase onto |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Switch 2 versions of Super Mario Odyssey and ARMS have their textures stored pre-tiled in the Switch 1 GOB layout. Their texture headers set word 2 bit 24 (
load_store_hintinTICEntry), while native titles such as OoT leave it clear. The rest of the header matches. This bit is used as an indication to use the Switch 1 layout.Type of change
Testing
Games tested:
ARMS (Switch 2) (5.5.1)
Super Mario Odyssey (Switch 2) (1.4.1)
Checklist
Screenshots / logs
Summary by CodeRabbit