Skip to content

Add announcement banner with registration instructions and associated… #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ellenegeld-eficode wants to merge 1 commit into
base: add-announcement-banner-with-instructions
Choose a base branch
from
Open

Add announcement banner with registration instructions and associated… #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 42 additions & 0 deletions .github/prompts/code-review.prompt.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
---
description: Perform a thorough code review
agent: ask
---

# Code Review

Perform a thorough code review of the currently selected code.

## Code to Review

${selection}

## Review Checklist

### 1. Correctness
- Does the code do what it's supposed to?
- Are there any logical errors?
- Are edge cases handled?

### 2. Security
- Is user input validated and sanitized?
- Are there SQL injection or XSS vulnerabilities?
- Is sensitive data handled properly?

### 3. Performance
- Are there any N+1 query issues?
- Is there unnecessary computation?

### 4. Readability
- Are names descriptive and consistent?
- Is the code self-documenting?

## Output Format

For each issue found, provide:
- **Severity**: 🔴 Critical / 🟡 Warning / 🔵 Suggestion
- **Line(s)**: Where the issue is
- **Issue**: What's wrong
- **Fix**: How to fix it

End with a summary of the overall code quality.
3 changes: 3 additions & 0 deletions src/static/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@
/>
</head>
<body>
<div class="announcement-banner">
📢 Activity registration is open until the end of the month. Don't lose your spot!
</div>
<header>
<h1>Mergington High School</h1>
<h2>Extracurricular Activities</h2>
Expand Down
8 changes: 8 additions & 0 deletions src/static/styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -654,6 +654,14 @@ footer {
font-size: 1rem;
}

.announcement-banner {
background-color: rgb(84, 146, 84);
color: white;
text-align: center;
padding: 15px;
font-weight: bold;
}

#logout-button {
padding: 3px 10px;
background-color: rgba(255, 255, 255, 0.2);
Expand Down