Allow user access to Sentry Event IDs or Aggregate ID#5926
Conversation
0b9a643 to
2748553
Compare
Jon-edge
left a comment
There was a problem hiding this comment.
Small comment, otherwise looks ok
src/components/cards/ErrorCard.tsx
Outdated
| ? errorIdentifier.eventId | ||
| : errorIdentifier.aggregateId | ||
| Clipboard.setString(id) | ||
| showToast(lstrings.fragment_copied) |
There was a problem hiding this comment.
Define a more specific string explaining what was copied
83d1b8f to
34157b6
Compare
34157b6 to
c2d0982
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| ? errorIdentifier.eventId | ||
| : errorIdentifier.aggregateId | ||
| Clipboard.setString(id) | ||
| showToast(lstrings.fragment_error_report_id_copied) |
There was a problem hiding this comment.
Toast message does not specify copied ID type
Low Severity
The PR discussion flagged this: the button label specifically says "Copy Event ID" or "Copy Aggregate ID" via copyLabel, but showToast uses a generic fragment_error_report_id_copied ("Error report ID copied") message regardless of which type was copied. This inconsistency between the specific button text and generic toast message reduces clarity for users trying to understand what was copied.
| string_warning: 'Warning', // Generic string. Same with wc_smartcontract_warning_title | ||
| string_report_error: 'Report Error', | ||
| string_report_sent: 'Report sent.', | ||
| string_report_sent: 'The report has been sent successfully.', |
There was a problem hiding this comment.
Shared string change may break AlertDropdown layout
Low Severity
The string_report_sent value changed from "Report sent." to "The report has been sent successfully." (nearly 3x longer). This string is also used in AlertDropdown.tsx in a compact horizontal row (flexDirection: 'row') with a checkmark icon. The longer text may cause layout issues, especially on smaller screens. The PR checklist shows small-screen testing was not completed.


CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have:
Note
Medium Risk
Touches error-reporting plumbing by changing
trackError’s return type and adds new UI behavior around error reporting/copying IDs. Risk is mainly around unintended UX or identifier handling regressions; core app logic and security boundaries are otherwise unchanged.Overview
After a user taps Report Error,
ErrorCardnow stores the identifier returned bytrackError, displays the resulting SentryeventId(oraggregateIdfor aggregated errors) in the card body, and changes the action button to Copy Event ID/Aggregate ID with a clipboard + toast confirmation.trackErrornow returns{ eventId }(or{ aggregateId }when expandingAggregateErrors) instead ofvoid, and English strings were updated/added for the new labels and revised “report sent” message.Written by Cursor Bugbot for commit c2d0982. This will update automatically on new commits. Configure here.