Skip to content

Allow user access to Sentry Event IDs or Aggregate ID#5926

Merged
samholmes merged 1 commit intodevelopfrom
sam/sentry-error-id
Feb 5, 2026
Merged

Allow user access to Sentry Event IDs or Aggregate ID#5926
samholmes merged 1 commit intodevelopfrom
sam/sentry-error-id

Conversation

@samholmes
Copy link
Contributor

@samholmes samholmes commented Feb 4, 2026

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

  • Yes
  • No

Dependencies

none

Requirements

If you have made any visual changes to the GUI. Make sure you have:

  • Tested on iOS device
  • Tested on Android device
  • Tested on small-screen device (iPod Touch)
  • Tested on large-screen device (tablet)

Note

Medium Risk
Touches error-reporting plumbing by changing trackError’s return type and adds new UI behavior around error reporting/copying IDs. Risk is mainly around unintended UX or identifier handling regressions; core app logic and security boundaries are otherwise unchanged.

Overview
After a user taps Report Error, ErrorCard now stores the identifier returned by trackError, displays the resulting Sentry eventId (or aggregateId for aggregated errors) in the card body, and changes the action button to Copy Event ID/Aggregate ID with a clipboard + toast confirmation.

trackError now returns { eventId } (or { aggregateId } when expanding AggregateErrors) instead of void, and English strings were updated/added for the new labels and revised “report sent” message.

Written by Cursor Bugbot for commit c2d0982. This will update automatically on new commits. Configure here.


@samholmes samholmes force-pushed the sam/sentry-error-id branch from 0b9a643 to 2748553 Compare February 4, 2026 20:15
Copy link
Collaborator

@Jon-edge Jon-edge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment, otherwise looks ok

? errorIdentifier.eventId
: errorIdentifier.aggregateId
Clipboard.setString(id)
showToast(lstrings.fragment_copied)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Define a more specific string explaining what was copied

@samholmes samholmes force-pushed the sam/sentry-error-id branch from 83d1b8f to 34157b6 Compare February 5, 2026 01:10
@samholmes samholmes enabled auto-merge February 5, 2026 01:13
@samholmes samholmes force-pushed the sam/sentry-error-id branch from 34157b6 to c2d0982 Compare February 5, 2026 01:50
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

? errorIdentifier.eventId
: errorIdentifier.aggregateId
Clipboard.setString(id)
showToast(lstrings.fragment_error_report_id_copied)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Toast message does not specify copied ID type

Low Severity

The PR discussion flagged this: the button label specifically says "Copy Event ID" or "Copy Aggregate ID" via copyLabel, but showToast uses a generic fragment_error_report_id_copied ("Error report ID copied") message regardless of which type was copied. This inconsistency between the specific button text and generic toast message reduces clarity for users trying to understand what was copied.

Fix in Cursor Fix in Web

string_warning: 'Warning', // Generic string. Same with wc_smartcontract_warning_title
string_report_error: 'Report Error',
string_report_sent: 'Report sent.',
string_report_sent: 'The report has been sent successfully.',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shared string change may break AlertDropdown layout

Low Severity

The string_report_sent value changed from "Report sent." to "The report has been sent successfully." (nearly 3x longer). This string is also used in AlertDropdown.tsx in a compact horizontal row (flexDirection: 'row') with a checkmark icon. The longer text may cause layout issues, especially on smaller screens. The PR checklist shows small-screen testing was not completed.

Fix in Cursor Fix in Web

@samholmes samholmes merged commit 5c81a40 into develop Feb 5, 2026
4 checks passed
@samholmes samholmes deleted the sam/sentry-error-id branch February 5, 2026 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants