-
Notifications
You must be signed in to change notification settings - Fork 279
New Crowdin updates #5923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
New Crowdin updates #5923
Conversation
| "amount_below_limit": "La cantidad está por debajo del límite mínimo de %1$s %2$s. Este límite mínimo está sujeto a cambios basados en las condiciones del mercado", | ||
| "no_amount_below_limit": "La cantidad está por debajo del límite mínimo. Inténtalo de nuevo con una cantidad mayor o habilita más proveedores en Ajustes → Ajustes de Cambio", | ||
| "no_amount_above_limit": "La cantidad está por encima del límite máximo. Inténtalo de nuevo con una cantidad menor o habilita más proveedores en Ajustes → Ajustes de Cambio", | ||
| "no_amount_above_limit": "La cantidad está por debajo del límite mínimo. Inténtalo de nuevo con una cantidad mayor o habilita más proveedores en Ajustes → Ajustes de Cambio", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Translation shows wrong error message for above-limit amounts
High Severity
The no_amount_above_limit translation was incorrectly changed from "above the maximum limit...try a smaller amount" to "below the minimum limit...try a larger amount". This makes it identical to no_amount_below_limit, causing Spanish-speaking users to see the wrong error message when their exchange amount exceeds the maximum limit. The translation now tells users to increase their amount when they actually need to decrease it.
Additional Locations (1)
| "amount_below_limit": "La cantidad está por debajo del límite mínimo de %1$s %2$s. Este límite mínimo está sujeto a cambios basados en las condiciones del mercado", | ||
| "no_amount_below_limit": "La cantidad está por debajo del límite mínimo. Inténtalo de nuevo con una cantidad mayor o habilita más proveedores en Ajustes → Ajustes de Cambio", | ||
| "no_amount_above_limit": "La cantidad está por encima del límite máximo. Inténtalo de nuevo con una cantidad menor o habilita más proveedores en Ajustes → Ajustes de Cambio", | ||
| "no_amount_above_limit": "La cantidad está por debajo del límite mínimo. Inténtalo de nuevo con una cantidad mayor o habilita más proveedores en Ajustes → Ajustes de Cambio", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spanish translation says opposite of intended meaning
High Severity
The no_amount_above_limit translation was changed to say the amount is "below the minimum limit" and to "try again with a higher amount" — but this key is used when the amount exceeds the maximum. The correct message (matching English) says it's "above the max limit" and suggests a "lower amount." This inverted translation will mislead Spanish-speaking users into doing the opposite of what they need to do.
Additional Locations (1)
| "gift_card_minimum_warning_footer": "Please select a different payment method or increase your purchase amount to at least %s.", | ||
| "gift_card_minimum_warning_header_1s": "The selected amount is below the minimum for %1$s.", | ||
| "gift_card_minimum_warning_footer_1s": "Please select a different payment method or increase your purchase amount to at least %1$s.", | ||
| "gift_card_minimum_warning_generic": "The selected amount is too small for this cryptocurrency. Please select a different payment method or increase your purchase amount.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New locale keys missing from base English file
Medium Severity
The new localization keys (gift_card_minimum_warning_header_1s, gift_card_minimum_warning_footer_1s, gift_card_minimum_warning_generic, card_amount_max_error_message_1s, card_amount_min_error_message_1s) are added to all non-English locale files, but the base English file (enUS.json) still only has the old keys without the _1s suffix. If the application code references these new keys, English-speaking users will see missing translations or raw key names instead of actual text.
Additional Locations (1)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| "amount_below_limit": "La cantidad está por debajo del límite mínimo de %1$s %2$s. Este límite mínimo está sujeto a cambios basados en las condiciones del mercado", | ||
| "no_amount_below_limit": "La cantidad está por debajo del límite mínimo. Inténtalo de nuevo con una cantidad mayor o habilita más proveedores en Ajustes → Ajustes de Cambio", | ||
| "no_amount_above_limit": "La cantidad está por encima del límite máximo. Inténtalo de nuevo con una cantidad menor o habilita más proveedores en Ajustes → Ajustes de Cambio", | ||
| "no_amount_above_limit": "La cantidad está por debajo del límite mínimo. Inténtalo de nuevo con una cantidad mayor o habilita más proveedores en Ajustes → Ajustes de Cambio", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spanish translation says opposite of intended message
Medium Severity
The no_amount_above_limit translation now says "La cantidad está por debajo del límite mínimo" (amount is BELOW the minimum limit) instead of "above the maximum limit." This is incorrect—the key indicates an amount exceeding the max, but the translated text now describes the opposite scenario and advises users to increase their amount when they actually need to decrease it. The old translation correctly said "por encima del límite máximo."
Additional Locations (1)
| "card_amount_max_error_message_s": "L'importo massimo di acquisto della carta è $%s", | ||
| "card_amount_min_error_message_s": "L'importo minimo d'acquisto è %s", | ||
| "card_amount_max_error_message_1s": "L'importo massimo di acquisto della carta è %1$s", | ||
| "card_amount_min_error_message_1s": "L'importo massimo di acquisto della carta è %1$s", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Italian minimum card message incorrectly says maximum
Medium Severity
The card_amount_min_error_message_1s translation says "L'importo massimo di acquisto della carta è %1$s" (maximum amount) but it's for the minimum error message. It appears to be a copy-paste error from card_amount_max_error_message_1s. The word "massimo" needs to be "minimo" to correctly indicate the minimum purchase amount.
Note
Low Risk
Primarily localization-only changes, but includes a likely incorrect Spanish
no_amount_above_limittranslation that could mislead users on swap limit errors.Overview
Updates localized string bundles across multiple languages (Crowdin sync), including new theme-selection labels (
settings_theme*) and new positional-parameter variants for several messages (e.g.gift_card_minimum_warning_*_1s,card_amount_*_1s) plus a new generic gift-card minimum warning.Also tweaks various existing translations (notably Italian), and changes the Spanish
no_amount_above_limitcopy to a minimum-limit message (potentially incorrect for “above limit” errors).Written by Cursor Bugbot for commit fb709cf. This will update automatically on new commits. Configure here.