Fix button spinner + label on async pending state #5713
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| : styles.labelTertiary, | ||
| children == null ? null : styles.labelWithIcon | ||
| ] | ||
| } |
There was a problem hiding this comment.
Bug: Inconsistent Visibility in Spinner/Pending States
The button's label now hides on spinner || pending, but the contentRowStyle (for icons/children) only hides on spinner. This inconsistency leaves icons visible alongside the spinner overlay when pending is true, while the label is hidden. Additionally, the labelInvisible style replaces labelBase, potentially losing includeFontPadding: false and causing subtle layout shifts.
Additional Locations (2)
There was a problem hiding this comment.
Not sure I fully understand this AI comment, but it might be worth double-checking.
swansontec
left a comment
swansontec
left a comment
There was a problem hiding this comment.
Approved, assuming the AI review is wrong. If the AI review is right, then perhaps we could fix that.
| : styles.labelTertiary, | ||
| children == null ? null : styles.labelWithIcon | ||
| ] | ||
| } |
There was a problem hiding this comment.
Not sure I fully understand this AI comment, but it might be worth double-checking.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have: