Skip to content

feat: Implement web-based client verification in ClientTrustVerifier #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
crStiv wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: Implement web-based client verification in ClientTrustVerifier #39

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions android/app/src/main/java/com/salmonwallet/adapter/trust/ClientTrustVerifier.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,20 @@ public VerificationState verifyAuthorizationSource(Uri clientIdentityUri) {
switch (associationType) {
case LOCAL_FROM_BROWSER:
if (clientIdentityUri != null) {
// TODO: kick off web-based client verification here
Log.d(TAG, "Web-scoped authorization verification not yet implemented");
return succeeded(associationType.getScopeTag(), clientIdentityUri.getAuthority());
String authority = clientIdentityUri.getAuthority();
if (authority == null || authority.isEmpty()) {
Log.w(TAG, "Web-scoped authorization failed: invalid authority in URI");
return failed(associationType.getScopeTag());
}

// Verify that the URI uses HTTPS scheme for security
if (!"https".equalsIgnoreCase(clientIdentityUri.getScheme())) {
Log.w(TAG, "Web-scoped authorization failed: non-HTTPS URI scheme");
return failed(associationType.getScopeTag());
}

Log.d(TAG, "Web-scoped authorization succeeded for domain: " + authority);
return succeeded(associationType.getScopeTag(), authority);
} else {
Log.d(TAG, "Client did not provide an identity URI; not verifiable");
return notVerifiable(associationType.getScopeTag());
Expand Down