Repository navigation
Enforce canonical byte limits before output expansion - #106
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Canonicalization checked its byte limit only after constructing the entire output. A small array sharing a 10,000-character string 20,000 times exhausted a constrained Node heap instead of returning the configured 1 MiB limit error.
Change
Account for UTF-8 string/key bytes, escapes, scalar values and structural punctuation incrementally. Reject oversized output before accumulation and preflight strings before allocating their escaped representation. Accepted canonical bytes and digest pins remain unchanged.
Verification
No policy outcomes, schema versions, releases, deployment settings, credentials or transactions change.