Repository navigation
Reject weak Ed25519 keys in CasePack checkpoint verification - #103
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CasePack checkpoint validation accepted an identity-point Ed25519 public key because OpenSSL could import it. If a caller pinned that malformed key, a signature constructed without a private key could satisfy checkpoint coverage. Reuse the existing strict key validator at the CasePack boundary and add a full CasePack regression with the forged signature and genuine checkpoint control.
Validation: 355 tests passed with six explicit Windows symlink skips; lint, typecheck, license/advisory checks, coverage, example, and isolated installed-package acceptance passed. Independent review rejected seven malformed key classes and accepted genuine controls. The new regression failed before the fix. No dependency or protocol change.