Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the README to document the stop_all!() and stop!(port) functions. The review feedback suggests improving the documentation's phrasing for clarity, exporting these functions from the module to enhance the user experience, adding test cases for the port-specific stop functionality, and ensuring the file ends with a newline character.
| and close all ports | ||
|
|
||
| ```julia | ||
| Browzarr.stop_all!() |
There was a problem hiding this comment.
The functions 'stop!' and 'stop_all!' are documented here as part of the public API, but they are not currently exported by the 'Browzarr' module in 'src/Browzarr.jl'. To improve the user experience and maintain consistency with the 'browzarr' function, consider exporting them. This would allow users to call them directly after 'using Browzarr' without needing the module prefix.
| or a specific port | ||
|
|
||
| ```julia | ||
| Browzarr.stop!(3000) |
There was a problem hiding this comment.
While 'stop_all!()' is used in the test suite, there are currently no tests for stopping a specific port via 'stop!(port::Int)'. Consider adding a test case in 'test/runtests.jl' to verify this functionality.
1 participant
No description provided.