Marked rows no longer hijack other actions - #6
Merged
Conversation
With --multi, fzf's accept returns the marked rows whenever any exist, so marking a repo for a later kill and then hitting Enter on a session silently created a numbered session from the forgotten mark instead. Marks only drive the ctrl-x kill flow, so Enter now clears them before accepting and always follows the cursor.
Ctrl-N with an empty query used to reuse the enter path's selection handling, so a forgotten mark could hijack it the same way. It now acts only on the query, and with nothing typed it reports there is nothing to create and exits 1, unlike a deliberate esc cancel.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.