Publish multi-platform images built on native runners - #25
Merged
Conversation
The image was built only for the runner's architecture, so every published tag was linux/amd64 and an arm64 host had no manifest to pull. Build each platform on a runner of its own architecture. Same-repo builds push untagged, addressed by digest, and a merge job joins the digests into one manifest list carrying the tags. Fork PRs cannot push, so they upload one archive per platform; publish-pr.yml joins those into a single multi-platform image and pushes it. Nothing is emulated on either path.
Diff CoverageDiff: origin/main...HEAD, staged and unstaged changesNo lines with coverage information in this diff. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The image was built only for the runner's architecture, so every published tag was
linux/amd64and an arm64 host had no manifest to pull — a deploy fails withno matching manifest for linux/arm64/v8.Each platform now builds on a runner of its own architecture:
ubuntu-latestfor amd64,ubuntu-24.04-armfor arm64. Same-repo builds push untagged, addressed by digest, and a merge job joins the digests into one manifest list carrying the tags.Fork PRs cannot push, and the digest merge needs both images in the registry, so they upload one archive per platform instead.
publish-pr.ymljoins those into a single multi-platform image and pushes it — still without checking out or executing fork code, and still deriving every tag from the API rather than from anything the fork controls.Nothing is emulated on either path.