[echo-server] make ingress fully compatible with various kubernetes versions#44
Open
treksler wants to merge 1 commit intoEalenn:masterfrom
Open
[echo-server] make ingress fully compatible with various kubernetes versions#44treksler wants to merge 1 commit intoEalenn:masterfrom
treksler wants to merge 1 commit intoEalenn:masterfrom
Conversation
treksler
commented
Apr 13, 2023
treksler
commented
- wrap pathType in a Kubernetes version check
- automatically handle annotations for kubernetes ingress class in older kubernetes versions
- eliminate duplicated code in backed definition
treksler
force-pushed
the
master
branch
2 times, most recently
from
ffa416a to
1f682bf
Compare
…ersions Signed-off-by: treksler <treksler@users.noreply.github.com>
Owner
|
Hello @treksler Thanks for the MRs, could you please change the version on all MRs and list the order to merge ? Everything seem good to me, but I can't merge :( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.