Add shuffle parameter support to Cylinder class#187
Merged
The9Cat merged 5 commits intohdf5compressfrom Dec 11, 2025
Merged
Conversation
Co-authored-by: The9Cat <25960766+The9Cat@users.noreply.github.com>
The9Cat
approved these changes
Dec 11, 2025
Co-authored-by: The9Cat <25960766+The9Cat@users.noreply.github.com>
The9Cat
approved these changes
Dec 11, 2025
Co-authored-by: The9Cat <25960766+The9Cat@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Address feedback on HDF5 compression implementation
Add shuffle parameter support to Cylinder class
Dec 11, 2025
Copilot stopped work on behalf of
The9Cat due to an error
December 11, 2025 14:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Cylinder class only exposed the
compressparameter for HDF5 cache configuration, while BiorthBasis Cylindrical exposed bothcompressandshuffle, creating an inconsistent API.Changes
"shuffle"toCylinder::valid_keysshuffleparameter (defaults totrue)setH5Params()call to pass both parametersExample
The implementation mirrors the existing pattern in
expui/BiorthBasis.cc.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.