Skip to content

bless_test_results: be a bit more forgiving about return code - #5042

Merged
jgfouca merged 2 commits into
masterfrom
jgfouca/btr_more_forgiving
Aug 28, 2026
Merged

bless_test_results: be a bit more forgiving about return code#5042
jgfouca merged 2 commits into
masterfrom
jgfouca/btr_more_forgiving

Conversation

@jgfouca

@jgfouca jgfouca commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Description

If the user tells BTR to bless everything it can, and BTR encounters a FAILed test that did not DIFF, that should not result in the overall BTR run being a failure; just skip that test. It should only be an overall failure if the user specifically requested the bless of that test. This behavior is necessary for our auto blesser to work correctly.

Checklist

  • My code follows the style guidelines of this project (black formatting)
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • I have added tests that exercise my feature/fix and existing tests continue to pass
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding additions and changes to the documentation

If the user tells BTR to bless everything it can, and BTR encounters
a FAILed test that did not DIFF, that should not result in the overall
BTR run being a failure; just skip that test. It should only be an
overall failure if the user specifically requested the bless of that
test.
@jgfouca
jgfouca requested a review from jasonb5 August 27, 2026 17:56
@jgfouca jgfouca self-assigned this Aug 27, 2026
@jgfouca jgfouca added the Responsibility: E3SM Responsibility to manage and accomplish this issue is through E3SM label Aug 27, 2026
@jgfouca
jgfouca merged commit 92ae0fd into master Aug 28, 2026
10 checks passed
@jgfouca
jgfouca deleted the jgfouca/btr_more_forgiving branch August 28, 2026 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Responsibility: E3SM Responsibility to manage and accomplish this issue is through E3SM

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant