Skip to content

Fix backend CI test crash caused by service initialization import cycle #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 4 commits into from
Closed

Fix backend CI test crash caused by service initialization import cycle #6

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a93a7fd
Initial plan
Copilot Jun 9, 2026
fd4d011
Fix circular import causing backend test failure
Copilot Jun 9, 2026
2ec2609
Cache lazy secureStorageService import in apiService
Copilot Jun 9, 2026
025569f
Refine cached lazy import for secure storage service
Copilot Jun 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions server/services/apiService.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
// apiService.js
import axios from "axios";
import config from "../config/config.js";
import secureStorageService from "./secureStorageService.js";
import { logger } from "../config/loggerConfig.js";

let secureStorageServiceModulePromise = null;

// API service for making HTTP requests
class ApiService {
constructor(options = {}) {
Expand Down Expand Up @@ -464,12 +465,18 @@ class ApiService {
`[API] ${process.env.NODE_ENV !== "production" ? "Mock " : ""}file upload: ${file.originalname} (${file.size} bytes)`
);

// Use local storage service instead of mocks
// Lazily load secureStorageService to avoid circular-import initialization
// issues during test/app bootstrap.
if (!secureStorageServiceModulePromise) {
secureStorageServiceModulePromise = import("./secureStorageService.js");
}
const { default: secureStorageService } =
await secureStorageServiceModulePromise;

if (!secureStorageService.initialized) {
await secureStorageService.initialize();
}

// Use the correct method name that exists in secureStorageService
return secureStorageService.uploadToIPFS(file);
}

Expand Down
Loading