Skip to content

Fix backend CI test failure by breaking api/storage service init cycle #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 3 commits into from
Closed

Fix backend CI test failure by breaking api/storage service init cycle #5

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
33b4dbf
Initial plan
Copilot Jun 9, 2026
633512d
fix(server): break api/secureStorage import cycle
Copilot Jun 9, 2026
1c7b3c8
fix(server): reset cached import promise on load failure
Copilot Jun 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion server/services/apiService.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
// apiService.js
import axios from "axios";
import config from "../config/config.js";
import secureStorageService from "./secureStorageService.js";
import { logger } from "../config/loggerConfig.js";

let secureStorageServicePromise;

// API service for making HTTP requests
class ApiService {
constructor(options = {}) {
Expand Down Expand Up @@ -464,6 +465,18 @@ class ApiService {
`[API] ${process.env.NODE_ENV !== "production" ? "Mock " : ""}file upload: ${file.originalname} (${file.size} bytes)`
);

// Lazy-load to avoid module initialization cycle:
// apiService -> secureStorageService -> hipaaComplianceService -> apiService
if (!secureStorageServicePromise) {
secureStorageServicePromise = import("./secureStorageService.js").then(
({ default: service }) => service
).catch((error) => {
secureStorageServicePromise = null;
throw error;
});
}
const secureStorageService = await secureStorageServicePromise;

// Use local storage service instead of mocks
if (!secureStorageService.initialized) {
await secureStorageService.initialize();
Expand Down
Loading