chome :phpstan level6とphpcsfixerを適用#187
Merged
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
- メソッド/プロパティ/配列の型宣言を付与 - WebHook を AbstractEntity 継承に変更 - SingleResultQuery::$entityManager を EntityManagerInterface に - Types::convertFieldMappingToType を null 許容に整理 - OAuth deleteAuthorizationCode の引数を ClientInterface に - ScopeValidationRule を Node 引数 + instanceof ガードに - UserResolveListener に PasswordAuthenticatedUserInterface ガードを追加 - PageInfoType の resolve 引数を SlidingPaginationInterface に - Assert\Collection を名前付き引数に - ApiCompilerPass の RuntimeException を sprintf でラップ - テスト: assertTrue(false) を self::fail() に、getClientEntity を 1 引数に、setStock を文字列引数に、DataProvider を static 化＋@return 修正、プロパティに = null 既定値 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
- プラグイン専用 phpstan.neon.dist (level 6) を追加 - CI に PHPStan 実行ステップを追加 - pull_request トリガーの branches フィルタを削除 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
- WebHook::$id を ?int = null / getId(): ?int に - getMutation() の @return を array<string, mixed> に - SearchFormQuery の resolve 引数 $args を array に - UpdateProductStockMutationTest の expectStock を ?string に - UpdateShippedMutationTest の $args @param を修正 - 不要 import を除去 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
dotani1111
force-pushed
the
chore/phpstan-level6
branch
from
f7f3ebc to
10e5008
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
4.4プラグイン を PHPStan level 6 に対応。
詳細
テストがブランチ名
xxx/xxxxxxxxのスラッシュ入りで動かなかったため、本体と合わせるPHPStanを追加
メソッド/プロパティ/配列に型宣言を付与
型不整合を修正（
WebHookのAbstractEntity継承、EntityManagerInterface化、Node引数 + ガード 等）RuntimeExceptionにパスを例外コードとして渡していたバグを修正CI に PHPStan ステップを追加
ローカルで php-cs-fixerを実行と修正