Skip to content

Update pre-commit and its dependencies - #854

Merged
forsyth2 merged 3 commits into
mainfrom
update-pre-commit-deps
Aug 14, 2026
Merged

Update pre-commit and its dependencies#854
forsyth2 merged 3 commits into
mainfrom
update-pre-commit-deps

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

This PR was auto-generated to update pre-commit and its dependencies.

@github-actions github-actions Bot added the DevOps CI/CD, configuration, etc. label Aug 14, 2026
@github-actions
github-actions Bot requested a review from forsyth2 August 14, 2026 16:40
@forsyth2

Copy link
Copy Markdown
Collaborator
rm -rf build
conda clean --all --y
conda env create -f conda/dev.yml -n zppy-pr854-env

fails with:

LibMambaUnsatisfiableError: Encountered problems while solving:
  - package flake8-isort-6.1.2-pyhd8ed1ab_0 requires isort >=5.0.0,<7, but none of the providers can be installed

Could not solve for environment specs
The following packages are incompatible
├─ flake8-isort 6.1.2  is installable and it requires
│  └─ isort >=5.0.0,<7 , which can be installed;
└─ isort 8.0.1  is not installable because it conflicts with any installable versions previously reported.

@forsyth2

Copy link
Copy Markdown
Collaborator

From Claude:


as of the current flake8-isort release (6.1.2), its dependency constraint is still isort >=5.0.0,<7. There's no newer flake8-isort release that raises the ceiling to allow isort 8.x yet.

So your options are:

Option A (recommended, safe fix): Don't bump isort all the way to 8.0.1. Keep it on the latest 6.x release that's still <7 (or stay at 6.0.1 if that's already the newest 6.x). This keeps flake8-isort==6.1.2's constraint satisfied.

Revert the isort bump in all three files:

-  - id: isort
-    rev: 8.0.1
+    rev: 6.0.1   # or latest 6.x
-  - isort ==8.0.1
+  - isort ==6.0.1   # or latest 6.x
-  "isort==8.0.1",
+  "isort==6.0.1",   # or latest 6.x

Option B: If you specifically need isort 7 or 8 features, you'd need to either drop flake8-isort entirely (isort's own --check-only / pre-commit hook can substitute), or wait until flake8-isort releases a version that relaxes its pin — which doesn't exist yet.

Given this is likely output from scripts/sync_pre_commit_versions.py blindly picking "latest," I'd guess the script needs a manual constraint added for isort so it doesn't outrun what flake8-isort supports. The cleanest immediate fix is Option A — just pin isort back within <7.

@forsyth2

Copy link
Copy Markdown
Collaborator

Went with Option A (isort ==6.0.1) to get the Conda env to solve. Also had to update a logger line to get pre-commit passing.

@forsyth2
forsyth2 merged commit 4735ef4 into main Aug 14, 2026
7 checks passed
@forsyth2
forsyth2 deleted the update-pre-commit-deps branch August 14, 2026 17:21
This was referenced Aug 14, 2026
@xylar

xylar commented Aug 15, 2026

Copy link
Copy Markdown
Collaborator

The bot will try to update this every month. Best to drop flake8-isort. @andrewdnolan will have a sense.

@andrewdnolan

Copy link
Copy Markdown

Hey @forsyth2! Just getting back from vacation.

Seems like it might be a good time to switch to ruff, which should support all the style/linting tools you're using (and more), while being much faster. I've made the switch in a couple repos and found this page to be helpful:

https://learn.scientific-python.org/development/guides/style/#ruff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DevOps CI/CD, configuration, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants