Skip to content

add new flag history_chemdyg_summary for ChemDyg variables - #66

Open
hsiangheleellnl wants to merge 8 commits into
NGD_v3atmfrom
hsiangheleellnl/v3atm_chemdyg
Open

add new flag history_chemdyg_summary for ChemDyg variables#66
hsiangheleellnl wants to merge 8 commits into
NGD_v3atmfrom
hsiangheleellnl/v3atm_chemdyg

Conversation

@hsiangheleellnl

Copy link
Copy Markdown

In order to reduce E3SM outputs for ChemDyg, I created a new flag "history_chemdyg_summary" to write out necessary variables. The run script needs to change to the followings:

**history_gaschmbudget_num = 2
nhtfrq = 0,0,-1,-24
mfilt = 1,1,240,30
avgflag_pertape = 'A','I','I','A'

fincl1 = 'CO','TROPE_P'
fincl3 = 'O3_SRF'
fincl4 = 'TCO','SCO','T'

tropopause_e90_thrd = 80.0e-9
history_chemdyg_summary = .true.**

@hsiangheleellnl
hsiangheleellnl requested review from tangq and wlin7 April 21, 2023 19:14

@tangq tangq left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggested some changes and had a couple comments.

Comment thread components/eam/src/chemistry/mozart/chemistry.F90 Outdated
Comment thread components/eam/src/chemistry/mozart/mo_neu_wetdep.F90
Comment thread components/eam/src/physics/cam/physpkg.F90
@hsiangheleellnl

Copy link
Copy Markdown
Author

@tangq I trimmed down O3_2Dxxx variabls and added CO_SRF as a default variable (instead of 3D CO).

@hsiangheleellnl
hsiangheleellnl requested a review from tangq May 12, 2023 21:38
@tangq

tangq commented May 14, 2023

Copy link
Copy Markdown
Contributor

@hsiangheleellnl , the hourly surface ozone output is not controlled by the user name list flag. If users don't specify fincl3 = 'O3_SRF', they can still run ChemDyg for other figures. Right?

Can you do a short test simulation and run ChemDyg on it to demonstrate the results? Post the simulation documentation page and the ChemDyg link here. If all look good, I will approve the PR. Thanks.

@hsiangheleellnl

Copy link
Copy Markdown
Author

@tangq Yes, if users don't specify fincl3 = 'O3_SRF, there is not h2 output but others stay the same. It would result in no surface O3 comparison when users run ChemDyg. Here is the full E3SM run script.

Here are the ChemDyg plots with the simplified flags. The webpage and ChemDyg configure script (.cfg) stay the same. Only tendency tables are missing on the webpage.

Note that history_chemdyg_summary can not be on with other flags (i.e., history_gaschmbudget_2D, history_gaschmbudget_2D_levels, history_UCIgaschmbudget_2D, and history_UCIgaschmbudget_2D_levels). The model will crash due to adding the same variables.

@tangq

tangq commented May 15, 2023

Copy link
Copy Markdown
Contributor

Note that history_chemdyg_summary can not be on with other flags (i.e., history_gaschmbudget_2D, history_gaschmbudget_2D_levels, history_UCIgaschmbudget_2D, and history_UCIgaschmbudget_2D_levels). The model will crash due to adding the same variables.

OK, we can leave it for now and remember to turn history_chemdyg_summary off when turning on these other flags.

A minor question, why the E3SM line not shown on this figure?

@hsiangheleellnl

Copy link
Copy Markdown
Author

Because I only ran a one-year simulation. E3SM results will show up on the CMIP TCO comparison when the E3SM simulation has two-year results or longer. (The function can plot a line but not a single point.)

@hsiangheleellnl

Copy link
Copy Markdown
Author

@wlin7 Wuyin, could you help merge this PR to NGD_v3atm? Thank you!

@tangq

tangq commented May 24, 2023

Copy link
Copy Markdown
Contributor

Note that history_chemdyg_summary can not be on with other flags (i.e., history_gaschmbudget_2D, history_gaschmbudget_2D_levels, history_UCIgaschmbudget_2D, and history_UCIgaschmbudget_2D_levels). The model will crash due to adding the same variables.

@hsiangheleellnl , just to note here what we decided on at the chemistry meeting today: when these diagnostic flags are set by user name list specifications, check if there are inconsistencies. If so, the flags with more diagnostic I/O should be true and history_chemdyg_summary be false.

Do you assume history_gaschmbudget_2D, history_gaschmbudget_2D_levels, history_UCIgaschmbudget_2D, and history_UCIgaschmbudget_2D_levels have to be ALL true or false simultaneously?

@hsiangheleellnl

Copy link
Copy Markdown
Author

histroy_chemdyg_summary is only conflict in history_gaschmbudget_2D and history_gaschmbudget_2D_levels. I modified the code to force history_chemdyg_summary to be false and other conflicted flags are true.

Comment thread components/eam/src/physics/cam/phys_control.F90
Comment thread components/eam/src/physics/cam/phys_control.F90 Outdated
Co-authored-by: tangq <tangq@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BFB PR leaves answer BFB

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants