Skip to content

Energy leak fixes in ZM - #60

Open
crterai wants to merge 2 commits into
NGD_v3atmfrom
crterai/eam/ZM_energy_leak
Open

Energy leak fixes in ZM#60
crterai wants to merge 2 commits into
NGD_v3atmfrom
crterai/eam/ZM_energy_leak

Conversation

@crterai

@crterai crterai commented Mar 17, 2023

Copy link
Copy Markdown

This fix by Xiaoliang Song plugs two energy leaks. The description, as provided by Xiaoliang:

1) flxsnow(i,k+1) = max(flxsnow(i,k+1), 0._r8) in the subroutine zm_conv_evap () 
This code is part of v2 and the current master. It may result in mass and energy leak when flxsnow <0.
In ZM microphysics, the overly strong snow detrainment may result in negative flxsnow. I have implemented 
an adjustment of snow detrainment in the microphysics code to fix this issue.

2) In the downdraft, the energy change related to ice-phase precipitation evaporation is not fully considered. 
Since the current convective microphysics scheme is designed for convective updraft, the representation of 
microphysical processes in downdraft is very crude. I have removed two line of code related to the change of 
sprd to maintain energy conservation. Since the total precipitation and evaporation is determined by rprd and evp,
this change should not have a noticeable impact on the simulation. 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants