NGD_v3atm with v2.1ocnice - #44
Open
wlin7 wants to merge 3492 commits into
Open
Conversation
Hommexx: Rewrite BoundaryExchange impl to support RRM and HV TOM speedup. * Rewrite Connectivity and BoundaryExchange impls to permit fully unstructured grids (RRM). * Speed up top-of-model (TOM) dissipation in both kernels and communication. * Add a new standalone-Homme C++-vs-F90 test for RRM support. Testing: * e3sm_developor and homme_integration pass against existing baselines on Chrysalis. (The new RRM test and the verifyBaselineResults tests fail in the HOMMEBFB set as expected.) * The standalone-Homme unit tests and cxx_vs_f90 tests pass on Weaver with the exception noted in E3SM-Project/scream#2126. * When incorporated into SCREAM, on Ascent, ERS_Ln362.ne30pg2_ne30pg2.F2010-SCREAMv1 passes. [BFB] except for a new RRM test in the HOMMEBFB test set.
…(PR #5398) Avoid keyword args for non-opt PIO args in CICE Avoid keyword/named arguments for non-optional arguments in PIO calls in CICE. [BFB]
Simplify fortran ASSERTs in one EAM file In components/eam/src/physics/cam/micro_mg_data.F90, use SHR_ASSERT_FL instead of SHR_ASSERT to avoid the need for creation of temporary error mesg. Fixes #5408 To test on gcp12, would also need PR #5414 Note this file is the only source unit using any SHR_ASSERT* macros in all of components/eam. [BFB]
Update machine files for OLCF AF machine - HPC11 This PR updates the machine setting for the US Air Force Cray EX supercomputer (HPC11) at ORNL (firstly added by #4781). Only GNU compiler is available on HPC11 at this moment. [BFB]
Minor modification for the HV reference profile for theta: use linear version near the surface This option is to enable rougher topography, to be used in SCREAM (not used in EAM) F case evaluation: https://acme-climate.atlassian.net/wiki/spaces/NGDNA/pages/3530719247/F2010+NH+evaluation [BFB] except for one standalone HOMME test ([theta-fdc12-test21.nl]) which is switched to this profile and will need a new baseline
See confluence for a more detailed description about these tags.
* Added molecular formula for species * Corrected minor syntax errors
*********1*********2*********3*********4*********5*********6*********7** Clean up the SPECIES session in both pp_chemUCI.inp (w/o aerosol) and pp_chemUCI_mam4.inp (w/ MAM4 aerosols) and make them consistent.
Changes include: * Clean up comments * Change pp_UCIchem.inp from windows to unix line ending * Added NO and NO2 in the "Ext Forcing" session in pp_UCIchem.inp
Some explicit tracers were wrongly defined as "implicit" type in the mechanism file. This causes 1) wrong ansowers for those should be solved with the explicit solver; 2) slow throughput by adding unnecessary tracers in the implicit array. This commit fixes these issues by defining the following tracers as the explicity type. * DMS, SO2, H2SO4 ** Fix MAM5 stratospheric sulfate solutions * CO, C2H6, C3H8, CH3COCH3 ** These tracers have slow reaction rates, so solve them explicitly * MAM tracers (i.e., *_a[1-5], expect SOA ones) ** Have no reactions. They are in the mechanism file only for the purpose of creating them. [Non-BFB]
Fix the broken output variables "*_trop", which are required by the STE ozone flux diagnostics. Also remove trailing whitespace in that part of code. [BFB]
remove all timers
… declaring and initialization together in subroutine calc_rime_density.
issues and to minize testing printout
Collaborator
Author
|
May keep this branch as a standalone. The PR is intended for documenting the differences introduced by rebasing and related discussions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
15 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NGD_v3atm up to PR #38 rebased with E3SM master up to PR #5410.