Add functionality to review web pages - #4
Open
forsyth2 wants to merge 85 commits into
Open
Conversation
forsyth2
changed the title
There was a problem hiding this comment.
Pull request overview
Adds new tooling and reporting to support reviewing WordPress-exported content
and Confluence pages for sensitive terms and publish/archive decisions for the
public-facing e3sm.org site.
Changes:
- Add new
e3sm-comms-exported-xml-reviewerCLI that parses WordPress export XML
and generates multiple review reports (sensitive terms, navigation issues, and
internal link validity). - Expand
e3sm-comms-e3sm-org-reviewerto use WordPress XML exports plus
Confluence-derived inputs to generate Markdown path/terms/action-item reports. - Improve website reviewer output by recording Confluence page created dates in
the sensitive-terms output and making Confluence traversal more fault-tolerant.
Reviewed changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| README.md | Updates command documentation and inputs/outputs for the new workflows. |
| pyproject.toml | Adds a new console script entry point for the exported XML reviewer. |
| examples/review_xml.bash | Adds a runnable example workflow for exported XML review. |
| examples/review_terms.bash | Adds a runnable example workflow for terms/path review. |
| e3sm_comms/website_reviewer/main.py | Adjusts default Confluence top-level input selection. |
| e3sm_comms/page_reviewer/utils_website_reviewer.py | Adds created-date context to sensitive-term output (but currently contains a syntax error). |
| e3sm_comms/page_reviewer/utils_base.py | Adds created_date on pages and introduces get_e3sm_url_status. |
| e3sm_comms/page_reviewer/confluence_page_reviewer.py | Improves resilience and logging during Confluence traversal and newsletter processing. |
| e3sm_comms/exported_xml_reviewer/main.py | Implements the new WordPress-exported XML reviewer and report generation. |
| e3sm_comms/exported_xml_reviewer/init.py | Declares the new package module. |
| e3sm_comms/e3sm_org_reviewer/main.py | Replaces the older reviewer with an XML-export-driven analyzer producing multiple Markdown reports. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
forsyth2
force-pushed
the
enable-disable-pages
branch
from
June 1, 2026 20:17
29b6b25 to
42d6888
Compare
exported_xml_reviewer replaces most of e3sm_org_reviewer, but four checks added during e3sm_org_reviewer's rewrite were never carried over. Ports them, each opt-in so default behavior is unchanged: - --use-expected-archived: pages expected to be archived that aren't - --use-keep-unchanged: exception list for pages we won't touch - --use-confluence (existing flag): flags published/whitelisted pages with no matching Confluence page - --check-non-published-access: live check that non-published pages are actually inaccessible First three add sections to wordpress_navigation_issues_report.md; the last gets its own wordpress_non_published_accessibility_report.md. Not ported: e3sm_org_reviewer's live-page term scan, since scanning the WordPress XML export directly is the more reliable source. e3sm_org_reviewer now has no unique capability left and can be dropped.
Collaborator
Author
|
The latest commit (8512e8c) ports over remaining functionality in Remaining action items:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add functionality to review web pages for inclusion/exclusion on the public-facing website.