Skip to content

Fix syntax in e3sm_omega_developer definition - #528

Merged
sbrus89 merged 1 commit into
E3SM-Project:developfrom
andrewdnolan:omega/test-suite-fix
Aug 27, 2026
Merged

Fix syntax in e3sm_omega_developer definition#528
sbrus89 merged 1 commit into
E3SM-Project:developfrom
andrewdnolan:omega/test-suite-fix

Conversation

@andrewdnolan

Copy link
Copy Markdown

There seems to have been a minor mistake in resolving the diffs from #521, which resulted in the e3sm_omega_developer test suite definition missing it's closing bracket.

Checklist

  • Testing

    aurora, oneapi-ifx, mpich

    • CTests Pass
    • Polaris omega_pr Pass

    chrysalis, oneapi-ifx, openmpi

    • CTests Pass
    • Polaris omega_pr Pass

    frontier, craygnu, mpich

    • CTests Pass
    • Polaris omega_pr Pass

    frontier, craygnu-mphipcc, mpich

    • CTests Pass
    • Polaris omega_pr Pass

    pm-cpu, gnu, mpich

    • CTests Pass
    • Polaris omega_pr Pass

    pm-gpu, gnugpu, mpich

    • CTests Pass
    • Polaris omega_pr Pass
  • Provide relevant details in a comment to the PR titled Testing with the following:

    • Document testing used to verify the changes including any tests that are added/modified/impacted.

@andrewdnolan andrewdnolan added the bug Something isn't working label Aug 27, 2026
@andrewdnolan

Copy link
Copy Markdown
Author

Testing

A first and very basic test is running:

python cime_config/tests.py

which prior to the changes from this PR produced:

  File "/autofs/nccs-svm1_home2/anolan/repos/Omega/test-suite-fix/cime_config/tests.py", line 11
    _TESTS = {                                                           
             ^                                                          
SyntaxError: '{' was never closed 

With the changes in this PR that commands now exists cleanly.

@grnydawn grnydawn left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Syntax checking with the Python interpreter by the originator should be sufficient for review. Approved.

@andrewdnolan

Copy link
Copy Markdown
Author

Testing

While it's overkill for this syntax fix, I ran the e3sm_omega_developer suite on frontier using craygnu compiler and had all tests pass.

I ran:

./create_test --compiler craygnu e3sm_omega_developer

which resulted in:

ERS_Vmct_Ln5.TL319_EC30to60E2r2.COMEGA-JRA1p5.frontier_craygnu.omega-jra_1958 (Overall: PASS) details:
ERS_Vmct.T62_oQU240.COMEGA-IAF.frontier_craygnu (Overall: PASS) details:
PEM_Vmct.T62_oQU240.COMEGA-IAF.frontier_craygnu (Overall: PASS) details:
SMS_Vmct_Ln5.TL319_EC30to60E2r2.COMEGA-JRA1p5.frontier_craygnu.omega-jra_1958 (Overall: PASS) details:
SMS_Vmct.T62_oQU240.COMEGA-IAF.frontier_craygnu (Overall: PASS) details:

@sbrus89

sbrus89 commented Aug 27, 2026

Copy link
Copy Markdown
Collaborator

Verified that e3sm_omega_developer passes with this change on Frontier (craygnu). Thanks for fixing and reviewing @andrewdnolan and @grnydawn and sorry I let this slip in.

@sbrus89
sbrus89 merged commit e0250c1 into E3SM-Project:develop Aug 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants