Set OMEGA_ARCH from the E3SM machine configuration - #526
Open
grnydawn wants to merge 1 commit into
Open
Conversation
* Derive GPU backend from `USE_CUDA`, `USE_HIP`, `USE_SYCL`, or threading settings * Forward `Kokkos_ARCH_*` and `Kokkos_ENABLE_*` options from `KOKKOS_OPTIONS` * Fail GPU builds when no Kokkos architecture is configured * Preserve EAMxx-provided `Kokkos::kokkos` when available * Fix `CASEROOT` handling for coupled and standalone builds * Handle bare and namespaced dependency targets safely * Use EKAT to build Kokkos in coupled builds without EAMxx * Add `BUILD_CONFIG_TEST` to verify `OMEGA_ARCH` matches the Kokkos execution space
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR sets
OMEGA_ARCHfrom the E3SM machine configuration. In addition, it resolves issues caused by differences between E3SM coupled builds with and without EAMxx.USE_CUDA,USE_HIP,USE_SYCL, or threading settingsKokkos_ARCH_*andKokkos_ENABLE_*options fromKOKKOS_OPTIONSKokkos::kokkoswhen availableCASEROOThandling for coupled and standalone buildsBUILD_CONFIG_TESTto verifyOMEGA_ARCHmatches the Kokkos execution spaceFix: #508
The following coupled test passed on
PM-CPU,PM-GPU, andChrysalis. Tests onFrontierandAuroraare still ongoing.A coupled test with
--res TL319_EC30to60E2r2 --compset COMEGA-JRA1p5looks good. It successfully passed both compilation and execution. However, the run ended prematurely due to the job allocation time limit onPM-CPU.Checklist
Documentation:
Linting
Building
Testing
chrysalis, gnu, openmpi
pm-cpu, gnu, mpich
pm-gpu, gnugpu, mpich
New tests: