adds start/stop options and fixes restart issues - #524
Open
philipwjones wants to merge 1 commit into
Open
Conversation
- adds a config stop option to support stopping
at a time, after an interval, or on a signal from coupler
- adds a start option to support start-up, continuation and
branch runs
- fixes some related clock and clock reset issues on restart that
were impacting a number of situations, especially in streams
for appended files
Author
|
Passes Ctests on Chrysalis. I also tested running 5 days and restarting for another 5 days and verified that the append option works to correctly write daily time slices to a single file (to verify fixing #482) |
Author
|
omega-buildnml PR tests are failing due to changes in the config file needed for this PR. |
Author
|
I will be mostly out of contact for about two weeks starting 8/25. I might be able to briefly respond to any issues and point to fixes but will not be able to access/modify code during that time. |
|
@philipwjones, just a quick note to say that I have seen this work is up and I really appreciate it! I'll get to reviewing it as soon as I can. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In an attempt to fix various restart issues, the methods for starting and stopping a run have been refactored. These are more fully described in the user and developer guides in the time stepping sections, but include:
These changes required changes to the input config so after this PR, users/developers will need to update their config files accordingly.
Checklist
Documentation:
Linting
Building
Testing
aurora, oneapi-ifx, mpich
chrysalis, oneapi-ifx, openmpi
frontier, craygnu, mpich
frontier, craygnu-mphipcc, mpich
pm-cpu, gnu, mpich
pm-gpu, gnugpu, mpich
Provide relevant details in a comment to the PR titled
Testingwith the following:have been run on and indicate that are all passing.
has passed, using the Polaris
e3sm_submodules/Omegabaseline-pfor both the baseline (Polarise3sm_submodules/Omega) and the PR buildFixes #482