Add MOAB coupler support for Omega - #523
Open
vijaysm wants to merge 7 commits into
Open
Conversation
Detect MOAB via OMEGA_MOAB_ROOT when COMP_INTERFACE=moab, define HAVE_MOAB, and conditionally add/link MoabInterface.cpp. No effect when MOAB is absent.
registerApplication only registered an app. Now builds an owned-cells mesh (vertex compaction, polygon elements, GLOBAL_ID tags), domain tags, and x2o/o2x tag get/set. Also fixes header typos that blocked compilation.
Pass full CIME field-name lists to the C++ side, pick MOAB vs MCT layout at compile time, and call the mesh/tag-storage functions around ocean init and run. Drops the unused runtime layout selection it replaces.
moabInit's app id was staying local to the C++ side. The coupler-side migration/mapping code reads seq_comm_mct's mpoid to locate the ocean mesh, so leaving it at -1 meant it never found it, causing the crash and memory corruption seen at runtime. Fortran now copies the id into mpoid.
component_init_areacor_moab reads area:aream:mask as one combined tag; a missing tag fails the whole read. aream gets a -9999 placeholder, same convention MCT uses, since the coupler fills in the real value later.
iMOAB_CreateElements expects connectivity entries to be 1-based (it computes firstVertex + connectivity[j] - 1). Compact vertex indices were written 0-based, so every vertex reference pointed one slot too early.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update interfaces to MOAB coupler by defining the Omega mesh in MOAB, and pushing/pulling data out of tags by defining and updating the data as needed by the driver. Tested only with a C-case, but I think it should work with any other case as well since the interface is uniform from the component standpoint.
Checklist
Documentation:
Linting
Building
Testing
aurora, oneapi-ifx, mpich
chrysalis, oneapi-ifx, openmpi
frontier, craygnu, mpich
frontier, craygnu-mphipcc, mpich
pm-cpu, gnu, mpich
pm-gpu, gnugpu, mpich
Provide relevant details in a comment to the PR titled
Testingwith the following:have been run on and indicate that are all passing.
has passed, using the Polaris
e3sm_submodules/Omegabaseline-pfor both the baseline (Polarise3sm_submodules/Omega) and the PR buildPerformance related PRs: Please include a relevant PACE experiment link documenting performance before and after.
New tests:
Stealth Features