Add support for running G-Cases - #507
Open
andrewdnolan wants to merge 56 commits into
Open
Conversation
Mesh overrides are optional; empty dict when not provided
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Accdidently was turning on tracer restroing which was causing crashes
Point to mesh with correct reconstruction variables names, which were changed as part of #480
…iscussion" This reverts commit 70b0ca2.
This reverts commit d32ee4d.
Recon to zonal/merid at cell centers happens in OcnToCplFields::copyToHost
ssh gradient if accumualted on device, defined at edges, and reconstructed at cell centers when copied to host
Switched all JRA compsets to be most recent JRA1p5
andrewdnolan
force-pushed
the
andrewdnolan/omega/g-case-coupling
branch
from
August 11, 2026 21:59
35e33b1 to
34b5483
Compare
Author
Testing: |
|
I just want to remind you that the SSH grad as produced by |
…ses already passed. * Add namespaces for the spdlog and yaml-cpp libraries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR hooks up the coupling channels needed to support G-cases. In order to support this, it:
AvgNormalVeolcityandAvgSshGradon edges for each ocean timestep (on the device). Reconstruction to cell centers, which still happens on device, occurs inOcnToCplFields::copyToHost. This prevents reconstruction happening every ocean timestep and instead happens only every coupling interval.o2x_So_u/o2x_So_vando2x_So_dhdx/o2x_So_dhdycoupler fields, respectively.components/omega/cime_config/config_compsets.xml.x2ocpl fields (e.g.Foxx_swnet,Faxa_lwdn, ...) and applies those to the Forcing class.o2x_So_sto the coupler.AbsSalinty->PracSalinity#467.This PR is blocked by:
o2x_So_uando2x_So_v).buildnmlinto a validated, testableomega_buildnmlpackage #494omega.yml, including setting of config options that apply to all coupled simulations.The branch used to open this PR has been rebased onto each of these PR. As these they are merged into develop, this branch should be rebased to remove the already merged commits.
Checklist
Documentation:
Linting
Building
Testing
aurora, oneapi-ifx, mpich
chrysalis, oneapi-ifx, openmpi
frontier, craygnu, mpich
frontier, craygnu-mphipcc, mpich
pm-cpu, gnu, mpich
pm-gpu, gnugpu, mpich
Provide relevant details in a comment to the PR titled
Testingwith the following:have been run on and indicate that are all passing.
has passed, using the Polaris
e3sm_submodules/Omegabaseline-pfor both the baseline (Polarise3sm_submodules/Omega) and the PR buildPerformance related PRs: Please include a relevant PACE experiment link documenting performance before and after.
New tests:
Stealth Features