forked from E3SM-Project/E3SM
-
Notifications
You must be signed in to change notification settings - Fork 8
Adds the thermo coupling #461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
alicebarthel
wants to merge
27
commits into
E3SM-Project:develop
Choose a base branch
from
alicebarthel:omega/add-thermo-forcing
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,125
−56
Open
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
ec56559
port forcing tendencies (thickness and tracers) + update doc, yml
alicebarthel 4956cf8
added the enthalpy of mass fluxes; CtFrz has public interface
alicebarthel 72f00b3
added a test for thermo forcing tendencies
alicebarthel 45c792f
made mass enthalpy flux dependent on thickness flag - under discussion
alicebarthel 36c9a37
draft a non-teos10 CtFrz in comments - WIP
alicebarthel 9b87769
updated the documentation
alicebarthel fae5a4a
Revert "made mass enthalpy flux dependent on thickness flag - under d…
alicebarthel 90f045e
updated the documentation
alicebarthel 1226b96
correction to pressure units and ctest
alicebarthel db218ac
update due to fill values and review comments
alicebarthel 965b549
resolve memory issue on GPUs
alicebarthel 554a9ff
inlines eos::calcPtFromCt in header with kokkos_function to fix gpu w…
katsmith133 0fd8e35
adds linear and constant eos options to thermal forcing
katsmith133 b5c586f
adds notes to docs and adds suggestions from review
katsmith133 a739dfc
Adds reset of forcing fields if not in stream
vanroekel 14065fc
Update components/omega/doc/devGuide/Forcing.md
cbegeman fded0f4
Fixup documentation
cbegeman 9fa07ce
remove SurfInsituTemp calcs
5bed059
fixes GPU failures on frontier
0864050
Revert "fixes GPU failures on frontier"
katsmith133 b35ff14
fixed GPU isssues on Frontier
katsmith133 c561101
fixes omega_pr errors on Frontier
katsmith133 e799907
changes assumptions about enthalpy calculation, per PR review comments
katsmith133 5772ba3
added limiter and Evap Enthalpy to TendencyTerms
alicebarthel d1212bc
renamed latent to specify evap and updated the docs
alicebarthel 85cff87
added missing arguments
alicebarthel 808185a
adds non-teos option to limiter
katsmith133 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.