Update Omega to C++20 - #405
Conversation
|
Due to replacing the |
|
@mwarusz, does E3SM-Project#8559 getting merged mean it is time to do another E3SM/master merge into Omega and then merge this PR? |
|
Yes, that would be good, as long as we don't run into any problems. I still need to rebase this PR. I can try to do a local merge after that to see if everything works as expected and, if there are no issues, we can go ahead with the switch. How does that sound ? |
grnydawn
left a comment
There was a problem hiding this comment.
The updates in this PR are a subset of those in the previous PR. Previously, all tests passed on Frontier, PM-CPU, PM-GPU, and Chrysalis. The current PR also passed all CTests on PM-GPU and Chrysalis. Approved.
|
No. At first, I misread E3SM-Project#8559. That PR only changes the standard and doesn't update Kokkos. The PR we need to fix #368 is E3SM-Project#8632, which hasn't been merged into E3SM yet. I am not sure if we want to merge this PR and do a master merge now, or do we want to wait for E3SM-Project#8632. I will leave this decision up to you. |
|
Thanks, that's what I had suspected. Let's wait for E3SM-Project#8632 before we merge #521. Given the level of testing associated with merging master into develop, I think it makes sense to do it once rather than twice. It's good to know all the pieces are almost in place to fix #368. Thanks for helping with this! |
This draft PR updates Omega C++ standard to C++20. E3SM is in the process to upgrading to Kokkos 5, which requires C++20. This PR has the necessary fixes on the Omega side.
Checklist
Testingwith the following:have been run on and indicate that are all passing.
has passed, using the Polaris
e3sm_submodules/Omegabaseline-pfor both the baseline (Polarise3sm_submodules/Omega) and the PR build