Update to kokkos5 - #410
Merged
Merged
Conversation
tcclevenger
force-pushed
the
tcclevenger/update_to_kokkos_5
branch
3 times, most recently
from
February 11, 2026 19:35
d3d3cc8 to
52a488e
Compare
tcclevenger
force-pushed
the
tcclevenger/update_to_kokkos_5
branch
3 times, most recently
from
May 6, 2026 16:07
6e21af1 to
b241922
Compare
tcclevenger
marked this pull request as draft
May 7, 2026 14:43
tcclevenger
force-pushed
the
tcclevenger/update_to_kokkos_5
branch
from
May 8, 2026 18:12
b241922 to
fb3df71
Compare
Contributor
|
I got the notification of the CI fail, got curious, and checked why we would fail with so few changes...and i found this in master... what the heck?!? Were we running "empty" tests?!? Edit: I suppose the test case was only meant to verify the code compiled correctly with various mixes of const/non-const inputs...so maybe not too serious... |
tcclevenger
force-pushed
the
tcclevenger/update_to_kokkos_5
branch
from
May 13, 2026 21:08
fb3df71 to
d7bb26a
Compare
tcclevenger
force-pushed
the
tcclevenger/update_to_kokkos_5
branch
from
July 16, 2026 04:00
d7bb26a to
4e10a11
Compare
tcclevenger
marked this pull request as ready for review
July 16, 2026 05:18
tcclevenger
marked this pull request as draft
July 16, 2026 19:56
tcclevenger
force-pushed
the
tcclevenger/update_to_kokkos_5
branch
from
July 20, 2026 18:45
bfd1b63 to
a1bc092
Compare
bartgol
previously approved these changes
Jul 20, 2026
tcclevenger
force-pushed
the
tcclevenger/update_to_kokkos_5
branch
from
August 6, 2026 15:31
a1bc092 to
d194ebf
Compare
tcclevenger
marked this pull request as ready for review
August 6, 2026 15:49
tcclevenger
force-pushed
the
tcclevenger/update_to_kokkos_5
branch
from
August 13, 2026 15:59
d194ebf to
4b9294c
Compare
Contributor
Author
|
5.1.0 actually works. Switching to that. |
bartgol
previously approved these changes
Aug 13, 2026
Right now, EKAT, homme, and EAMxx are only compatible with legacy views.
Also, turn off deprecated code in testing
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
tcclevenger
force-pushed
the
tcclevenger/update_to_kokkos_5
branch
from
August 13, 2026 20:39
4b9294c to
ecd46a2
Compare
Contributor
Author
|
@bartgol Ignore what I said earlier, 5.1.0 works for landice. Updated the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update EKAT to Kokkos 5.0.1.
The most notable change here is the option
Kokkos_ENABLE_IMPL_VIEW_LEGACY=ON. Right now we need this since EKAT, Hommexx, and EAMxx use legacy features to subview, in particular. This needs to be addressed as, an impl feature, it will disappear w/o deprecation.Motivation
This will allow MALI to use updated Trilinos and EAMxx to use modern C++ features.