Removes MPP submodule - #8665
Open
bishtgautam wants to merge 3 commits into
Open
Conversation
Contributor
|
E3SM LEGEND AWARD FOR DRASSTIC REDUCTION OF LOC (AND SUBMOD) |
bishtgautam
force-pushed
the
bishtgautam/lnd/delete-mpp
branch
from
August 25, 2026 15:51
b2c590f to
6ed66c2
Compare
Contributor
Author
|
@yfang-pnnl, I'm deleting the MPP submodule in this PR. Since we have the MOAB-based infrastructure to do lateral halo-exchange in ELM (thanks to @vijaysm), I don't believe we need MPP for neither the VSFM physics nor the PETSc-based VecScatter/Gather infrastructure to do lateral halo-exchange. Do you agree? |
Contributor
|
I approve this PR based specifically on the conclusion that PETSc infrastructure is not required for halo exchanges associated with lateral transport. |
yfang-pnnl
approved these changes
Aug 25, 2026
Contributor
Author
|
The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the MPP submodule from ELM.
[BFB]
The physics provided by the submodule hasn't been used and there
aren't any plans of using that physics. So, it is time to say goodbye and
reduce the number of submodules. If we need the physics provided by
this submodule, we most likely will implement it natively without relying
on PETSc to solve many small system of nonlinear equations with DOFs
of 10 or 15.