Skip to content

Fix e3sm.exe link order so PnetCDF comes after SCORPIO's piof/pioc #8655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rljacob wants to merge 1 commit into
base: master
Choose a base branch
from
+19 −7
Open

Fix e3sm.exe link order so PnetCDF comes after SCORPIO's piof/pioc #8655

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 19 additions & 7 deletions components/cmake/build_model.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,19 +263,31 @@ macro(build_model COMP_CLASS COMP_NAME)
add_executable(${TARGET_NAME})
target_sources(${TARGET_NAME} PRIVATE ${REAL_SOURCES})

# driver-mct/main sources (e.g. cime_comp_mod.F90) use netcdf directly, but
# the component libraries only link netcdf PRIVATEly (via csm_share), so
# its usage requirements (e.g. include dirs for netcdf.mod) do not
# propagate up to this exe target. Find/link it explicitly here too.
find_package(NETCDF REQUIRED)
target_link_libraries(${TARGET_NAME} netcdf)

foreach(ITEM IN LISTS COMP_CLASSES)
if (NOT ITEM STREQUAL "cpl")
target_link_libraries(${TARGET_NAME} ${ITEM})
endif()
endforeach()

# driver-mct/main sources (e.g. cime_comp_mod.F90) use netcdf directly, but
# the component libraries only link netcdf PRIVATEly (via csm_share), so
# its usage requirements (e.g. include dirs for netcdf.mod) do not
# propagate up to this exe target. Pull in just the include dirs here.
#
# Deliberately NOT using target_link_libraries(${TARGET_NAME} netcdf):
# CMake treats "netcdf" as a single graph node, so linking it directly to
# this executable pins its (and PnetCDF's) position to wherever it's
# first encountered, ahead of the component libraries below that also
# transitively link it via csm_share -> spio. But piof/pioc (also pulled
# in via csm_share -> spio) reference PnetCDF symbols, so libpnetcdf.a
# must come after them on the link line, or the linker drops its symbols
# before piof/pioc need them. Only requesting the include dirs avoids
# adding that extra, mis-ordering link edge, while the link libraries
# still reach this target correctly ordered via csm_share -> spio.
find_package(NETCDF REQUIRED)
get_target_property(NETCDF_INTERFACE_INCLUDE_DIRS netcdf INTERFACE_INCLUDE_DIRECTORIES)
target_include_directories(${TARGET_NAME} PRIVATE ${NETCDF_INTERFACE_INCLUDE_DIRS})

if (USE_MOAB)
target_link_libraries(${TARGET_NAME} ${MOAB_LIBRARIES})
target_include_directories(${TARGET_NAME} PRIVATE ${MOAB_INCLUDE_DIRS})
Expand Down