EAMxx: IOP create_horiz_remappers to DataInterpolation Class - #8634
Merged
Conversation
… to avoid duplicating the logic in multiple places.
odiazib
marked this pull request as ready for review
August 14, 2026 18:12
odiazib
added
BFB
bartgol
reviewed
Aug 14, 2026
bartgol
approved these changes
Aug 17, 2026
Contributor
Author
|
@bartgol can we merge this PR? |
bartgol
added a commit
that referenced
this pull request
Aug 19, 2026
…t (PR #8634) This PR refactors the IOP logic out of the atmosphere process and into the DataInterpolation class. Since DataInterpolation is instantiated and reused in multiple locations within eamxx-mam4xx, centralizing this logic avoids code duplication. [BFB]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the IOP logic out of the atmosphere process and into the DataInterpolation class. Since DataInterpolation is instantiated and reused in multiple locations within eamxx-mam4xx, centralizing this logic avoids code duplication.
I will update the eamxx-mam4xx call to
create_horiz_remappers(spa_map_file, m_iop_data_manager)in PR #8615Once PR #8615, PR #8430, and this PR are merged into master, we will be able to run MAM4xx+DPxx.
I will also close PR #8517.