EAMxx: incorporating a fix for fetching aerosol properties - #8622
EAMxx: incorporating a fix for fetching aerosol properties#8622jeff-cohere wants to merge 1 commit into
Conversation
jeff-cohere
added
bug fix PR
EAMxx
|
Here's the relevant mam4xx PR. |
|
Looks like #8620 needs to go in before this one. |
e147cc3 to
f605d64
Compare
|
After running an EAMxx-MAM4xx ne30pg2 case on Chrysalis, we observed that this PR produces BFB identical results. See Below. I added a few print statements to the routines modified by eagles-project/mam4xx#573, and it appears that these routines are not invoked by the EAMxx-MAM4xx interfaces. In conclusion, the bug in the physical properties did not affect our production cases because the routines in which it was present are not used by EAMxx-MAM4xx. |
|
Thanks, Oscar! I'm closing this for now since it has no effect on EAMxx. |
|
We're not yet convinced that these functions are unused in all cases. More soon. |
|
#8672 confirms that the routines containing the bugs are not used by eamxx-mam4xx. In addition, note that this PR is BFB. |
3 participants
This PR fast-forwards the mam4xx submodule to fix indexing errors that were
bestowing incorrect aerosol species properties to aerosols. Perhaps it will address
or improve what we are observing in #8550.
[non-BFB]