Change tracer mass conservation tolerance to allow test to pass - #8395
Merged
Conversation
Contributor
Author
|
@rljacob -- I'm not sure who else to add as a reviewer for a homme change |
Contributor
Author
|
note that this test still passes on chrysalis |
Member
|
Does it pass with oneapi on Chrysalis? |
Contributor
Author
|
I'll have to test that, @rljacob. It's passing with intel |
ambrad
approved these changes
May 14, 2026
ambrad
left a comment
ambrad
left a comment
Member
There was a problem hiding this comment.
This minor change to the tolerance is fine.
Contributor
Author
|
It passed with oneapi-ifx as well on chrysalis |
rljacob
approved these changes
May 14, 2026
Member
|
@bartgol can you approve so SNL testing will run? |
bartgol
approved these changes
May 15, 2026
jonbob
added a commit
that referenced
this pull request
May 18, 2026
…#8395) Change tracer mass conservation tolerance to allow test to pass A change to mpas-seaice in d40b843 caused an F-case test, SMS_Ld3.ne4pg2_oQU480.F2010.pm-cpu_intel.eam-thetahy_sl_pg2_mass to fail with a post-run error. The tracer CO2_FFF has index 84 and ends up with a mass error just above the tolerance: tracer 84 : mass rel err 1.710e-15 tol: 1.621e-15 This PR increases the tolerance factor and allows the failing test to pass. Fixes #8373 [BFB]
Contributor
Author
|
merged to next |
Contributor
Author
|
merged to master -- failing test now runs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A change to mpas-seaice in d40b843 caused an F-case test,
SMS_Ld3.ne4pg2_oQU480.F2010.pm-cpu_intel.eam-thetahy_sl_pg2_mass
to fail with a post-run error. The tracer CO2_FFF has index 84 and ends up with a mass error just above the tolerance:
tracer 84 : mass rel err 1.710e-15 tol: 1.621e-15
This PR increases the tolerance factor and allows the failing test to pass.
Fixes #8373
[BFB]