Skip to content

Fix linoz data file for 1pctCO2 use_case - #5926

Merged
wlin7 merged 1 commit into
masterfrom
wlin/atm/fix_1pctco2_linozfile
Sep 14, 2023
Merged

Fix linoz data file for 1pctCO2 use_case#5926
wlin7 merged 1 commit into
masterfrom
wlin/atm/fix_1pctco2_linozfile

Conversation

@wlin7

@wlin7 wlin7 commented Sep 13, 2023

Copy link
Copy Markdown
Contributor

PR #5860 updated linoz data files for use cases. But the PR did not involve the use_case file for WCYCL1850-1pctCO2
as it was introduced at a later time.

This fixes WCYCL1850-1pctCO2 tests, though some machines were able to run with the old file.

[non-BFB] only for compy and anvil prod tests that were able to run with the old file

@jinboxie jinboxie left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is supposed to be using the new file rather than the old. It is now modified correctly.

wlin7 added a commit that referenced this pull request Sep 14, 2023
Fix linoz data file for 1pctCO2 use_case

PR #5860 updated linoz data files for use cases. But the PR did not involve
the use_case file for WCYCL1850-1pctCO2 as it was introduced at a later time.

This fixes WCYCL1850-1pctCO2 tests, though some machines were able to run with the old file.

[non-BFB] only for compy and anvil prod tests that were able to run with the old file.
@wlin7

wlin7 commented Sep 14, 2023

Copy link
Copy Markdown
Contributor Author

Merged to next.

This should fix SMS_Ld1.ne30pg2_EC30to60E2r2.WCYCL1850-1pctCO2.chrysalis_intel.allactive-wcprod_1850_1pctCO2 failure. It will also override this test on compy and anvil which were able to run with the old linoz data file. Bless requests already submitted for compy and anvil prod test suites. To merge the PR to master once any of the compy/anvil/chrysalis prod tests returns an expected diff. This should avoid repeating blessing the test for compy/anvil.

@wlin7
wlin7 merged commit 84e5056 into master Sep 14, 2023
@wlin7
wlin7 deleted the wlin/atm/fix_1pctco2_linozfile branch September 14, 2023 12:23
@wlin7

wlin7 commented Sep 14, 2023

Copy link
Copy Markdown
Contributor Author

Merged to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants