Adds a 1D bgc forcing test case and a bgc D-TEST - #5506
Conversation
Atmospheric, ocean and biogeochemical data from the 2004 Ice Station Polarstern (ISPOL) Weddell Sea (67.9S, 54W) experiment from June 16, 2004 to December 31, 2004. Core 2 from the ISPOL location fills out the remainder of the year. A uniform_1D initial condition was added for flexible initialization. A new testcase - single_cell_ispol - was added to MPAS-Dev/MPAS-Seaice_standalone_framework to verify this forcing and initializtion. BFB
Properly initializes enthalpy and salinity using colpkg_init_trcr
Seasonal bgc forcing is time-dependent only and can be used for a DTESTM-BGC -Adds nCells dimension to ocean and atm ISPOL forcing to simplify code -Updates ISPOL forcing files -Adds a new namelist option: config_forcing_bgc_type='ISPOL' BFB
|
This branch was created in response to the concerns of #5282. It includes 1D ISPOL forcing for a single column bgc testcase but has been adapted to be used in a BGC D-TEST. In addition, atm and ocean forcing files include an nCells dimension. |
|
Completed the ispol single sell testcase and a 3-year DTESTM-BGC |
New namelist field is part of E3SM-Project/E3SM#5506
|
The code changes pass the single_cell_ispol test case: |
|
@eclare108213 and @akturner -- could you please review this whenever you get a chance? Thanks |
eclare108213
left a comment
There was a problem hiding this comment.
These changes look fine to me but now there are conflicts that must be resolved.
Nicole tested both single-cell and D cases earlier.
|
@njeffery -- I pushed changes to that Registry is consistent with the documentation you added in the namelist_files. If you get a chance, could you make sure they're what you wanted? I'l try a test merge and see if the file conflicts are easily resolved during that process |
|
@njeffery -- I can manage the conflicts during the merge process |
#5506) Adds a 1D bgc forcing test case and a bgc D-TEST New data file with atmospheric, ocean and biogeochemical data from the 2004 Ice Station Polarstern (ISPOL) Weddell Sea experiment from June 16, 2004 to December 31, 2004. Core 2 from the ISPOL location fills out the remainder of the year. A uniform_1D initial condition was added for flexible initialization of BGC. Atmophere and Ocean forcing use the nCells dimension of 1. A new testcase - single_cell_ispol - was added to the MPAS-Seaice_standalone_framework to verify this forcing and initialization. The ISPOL bgc forcing can be used with any of the gridded physics forcing datasets for testing purposes. [NML] [BFB]
|
passes:
with expected NML DIFFs merged to next |
|
merged to master and expected NML DIFFs blessed on all platforms except mappy -- which did not report |
|
Thanks @jonbob ! |
Atmospheric, ocean and biogeochemical data from the 2004 Ice Station Polarstern (ISPOL) Weddell Sea (67.9S, 54W) experiment from June 16, 2004 to December 31, 2004. Core 2 from the ISPOL location fills out the remainder of the year.
A uniform_1D initial condition was added for flexible initialization of BGC. Atmophere and Ocean forcing use the nCells dimension of 1. A new testcase - single_cell_ispol - was added to
MPAS-Dev/MPAS-Seaice_standalone_framework to verify this forcing and initializtion. MPAS-Dev/MPAS-Seaice_standalone_framework#15
The ISPOL bgc forcing can be used with any of the gridded physics forcing datasets for testing purposes.
[NML]
[BFB]