Repository navigation
ci: move lanes to self-hosted runners — never use GitHub-hosted - #141
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Mira PR WalkthroughThis PR migrates all CI build lanes from GitHub-hosted runners to self-hosted runners for Linux, Windows, and macOS (x64). ARM64 image lanes remain on
1 file reviewed · 1 comment (
|
There was a problem hiding this comment.
Mira Review Summary
The workflow ployz-build.yml declares a 'runner' workflow_dispatch input at line 7 but the job at line 13 hardcodes runs-on, rendering the input unused. This makes the runner input ineffective for selecting runners. The issue is a configuration warning that should be addressed.
Key Issues
| Issue | Location | |
|---|---|---|
| 🔴 | ployz-build.yml declares a 'runner' input but hardcodes runs-on, making the input useless | .github/workflows/ployz-build.yml:13 |
….3, decode-uri-component 0.5.1
There was a problem hiding this comment.
Mira Review Summary
No issues found in the provided diffs. The changes are routine dependency updates (golang.org/x/net v0.61.0 → v0.62.0 in both go.mod files, echo/v4 v4.15.3 → v4.16.1 and go-colorable v0.1.14 → v0.1.15 in apps/desktop/go.mod) and security hardening via npm overrides for decode-uri-component and node-forge in apps/mobile/package.json. All version bumps appear consistent and non-breaking. The PR title mentions CI runner changes but those workflow modifications were presumably addressed in the previous review round (referenced .github/workflows/ployz-build.yml lines already resolved).
| github.com/gorilla/websocket v1.5.3 // indirect | ||
| github.com/jchv/go-winloader v0.0.0-20210711035445-715c2860da7e // indirect | ||
| github.com/labstack/echo/v4 v4.15.3 // indirect | ||
| github.com/labstack/echo/v4 v4.16.3 // indirect |
There was a problem hiding this comment.
Security issue
Known vulnerabilities in github.com/labstack/echo/v4@v4.16.3
OSV.dev reports 2 known vulnerabilities affecting github.com/labstack/echo/v4@v4.16.3, introduced by this PR:
- GO-2026-6872 unknown: Rate Limiter Bypass via Spoofed X-Forwarded-For Header in Default Configuration in github.com/labstack/echo — fixed in 5.1.0
- GO-2026-6875 unknown: Reverse Proxy Forwards Attacker-Supplied X-Real-IP to Upstream by Default in github.com/labstack/echo — fixed in 5.4.0
Upgrade to 5.1.0 or later.
Prompt for AI Agents
In apps/desktop/go.mod, upgrade the dependency github.com/labstack/echo/v4 from v4.16.3 to a non-vulnerable version (5.1.0, 5.4.0). Update any associated lockfile entries.
Not useful? Reply
@mira-tdvorak rejectto dismiss this suggestion.
All lanes moved off GitHub-hosted runners to self-hosted. Linux →
[self-hosted, linux, x64], Windows →[self-hosted, windows, x64](hp-win11), macOS →[self-hosted, macos, x64](osx-nab9). arm64 image lanes stay onubuntu-24.04-arm— no ARM hardware in fleet and QEMU SIGILLs on node:20-alpine (documented in-file).