Repository navigation
Android: fix compile error from duplicate companion object (#414 follow-up) - #416
Merged
Merged
Conversation
Dvorinka#414 added a second companion object for the 2FA result codes, but the class already had one holding the OAuth constants. Kotlin allows only one per class, so compileDebugKotlin failed with "Only one companion object is allowed per class" and unresolved OAUTH_* references. Move the two constants into the existing companion object. Verified with ./gradlew :app:assembleDebug on JDK 21.
Mira PR Walkthrough❌ Review failed — click for detailsThe code review failed to complete due to an unexpected error. Stage: Code review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#414 added a second
companion objecttoLoginViewModelfor the 2FA result codes, but the class already had one holding the OAuth constants. Kotlin allows only one per class, so:app:compileDebugKotlinon currentmasterfails with:This moves
CODE_NOT_FULLY_SUCCESSandCODE_NOT_FOUNDinto the existing companion object. No behaviour change.Verified with
./gradlew :app:assembleDebugon JDK 21 (AGP 8.9.3). Apologies for the breakage: I had no Android SDK available when opening #414 and noted that there; this is the first real compile.