Say what the init system toggle actually does - #246
Open
kacperpaczos wants to merge 1 commit into
Open
Conversation
"Adds systemd support - ignore if you're not sure" leaves out the half that catches people: `--init` also unshares the process namespace, so the host's processes stop being visible inside the box. The toggle makes a box more isolated, and it reads like it does the opposite - which is how it gets switched on by someone trying to reach more of the host. The subtitle now names both effects, and a tooltip says when the option is wanted (services that run inside the box) and when it is not (using the host's tools). The old string is not translated in any shipped .po - only in the .pot - so no translation is lost by rewording it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #245
distrobox create --initdoes two things, and the toggle's subtitle only mentioned one:So the option makes a box more isolated. "Adds systemd support - ignore if you're not sure" reads like the opposite - closer to a full system, closer to the host - which is exactly how it gets switched on by someone trying to reach the host from inside a box.
The subtitle now names both effects, and the detail goes in a tooltip, following the hostname row right below it:
Text only - the flag passed to distrobox is unchanged.
Testing
cargo build --releaseclean,cargo test5 pass (unchanged - no logic here),cargo fmt --checkreports the same four pre-existing hunks as master and no new ones.Checked before writing:
Adds systemd support - ignore if you're not sureappears only inpo/boxbuddy.potand in none of the shipped.pofiles, so rewording it does not throw away a translation anyone has made. If you would rather keep the old string and put the missing half in the tooltip alone, that is a one-line change - say the word.