Try symbolic icon names before full-colour ones for the install row - #231
Open
kacperpaczos wants to merge 1 commit into
Open
Try symbolic icon names before full-colour ones for the install row#231kacperpaczos wants to merge 1 commit into
kacperpaczos wants to merge 1 commit into
Conversation
get_available_icon_name takes the first name the active icon theme has, and INSTALL_PACKAGE_ICON_NAMES put full-colour system-software-install in front of install-symbolic. Breeze has no system-software-install-symbolic but does have install-symbolic, so KDE users got a full-colour icon in an otherwise monochrome list - symbolic icons follow the text colour, full-colour ones do not, which makes the odd one out very visible. Adwaita resolves the first name as before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #230
get_available_icon_namewalks its candidate list and takes the first name the active icon theme has.INSTALL_PACKAGE_ICON_NAMESput the full-coloursystem-software-installsecond, in front ofinstall-symbolic— so on Breeze, which has nosystem-software-install-symbolicbut does haveinstall-symbolic, the resolver stopped at the full-colour icon and the row stood out from the otherwise monochrome list. Symbolic icons also follow the text colour and grey out with an insensitive row; full-colour ones do neither, which is what makes the odd one out so visible.The list now tries every symbolic candidate before the full-colour last resort:
system-software-install-symbolic→install-symbolic→download-symbolic→system-software-install. Breeze resolvesinstall-symbolic; Adwaita keeps resolvingsystem-software-install-symbolic, exactly as before.Adwaita, unchanged by this PR:
Testing
Captures are from a virtual display with a stub
distrobox list: Breeze through the session's icon theme, Adwaita through an isolated settings backend left at its defaults. The one-line list change is the whole diff, so the behaviour difference is exactly what the screenshots show.