Skip to content

Require stopping a box before it can be deleted #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kacperpaczos wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Require stopping a box before it can be deleted #218

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fb4a2be
feat: don't let a running box be deleted until it is stopped
kacperpaczos Aug 22, 2026
8878580
simplify: check the running state inline
kacperpaczos Aug 23, 2026
8186564
feat: grey out Delete Box without a subtitle
kacperpaczos Aug 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -538,6 +538,11 @@ fn make_box_tab(dbox: &DBox, window: &ApplicationWindow, tab_num: u32) -> gtk::B
let win_clone = window.clone();
delete_row.connect_activated(move |_row| on_delete_clicked(&win_clone, del_bn_clone.clone()));

// Deleting a running box would pull it out from under whatever is using it,
// so make the user stop it first. The Stop button on the header is right
// there while the box is up; once it is down the row enables itself.
delete_row.set_sensitive(!dbox.is_running);

// Clone Box Icon
let clone_icon = gtk::Image::from_icon_name(&get_available_icon_name(COPY_ICON_NAMES));

Expand Down